Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript compare doesnt returns boolean #13

Closed
xaviergxf opened this issue Mar 13, 2019 · 1 comment
Closed

Typescript compare doesnt returns boolean #13

xaviergxf opened this issue Mar 13, 2019 · 1 comment

Comments

@xaviergxf
Copy link
Contributor

Hi,

The typescript definition uuid.d.ts on function compare returns a boolean, but in reality it returns a number. When using this on a filter it inverses the desired results. Can you please fix this issue? How about creating a more specific method like equal which returns a boolean?

Thanks
rse added a commit that referenced this issue Mar 13, 2019
@rse
fix return value type of compare() method: it is a number and not boo…
a66c90f 
…lean (#13)
@rse
Copy link
Owner

rse commented Mar 13, 2019

Now fixed. Thanks.

@rse rse closed this as completed Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rse @xaviergxf