Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue that needs reproducing: multiple points #13

Closed
vsoch opened this issue Oct 13, 2020 · 2 comments
Closed

Issue that needs reproducing: multiple points #13

vsoch opened this issue Oct 13, 2020 · 2 comments

Comments

@vsoch
Copy link
Collaborator

vsoch commented Oct 13, 2020

If we look at http://us-rse.org/rse-stories/assets/img/phenotypes/cferenba-rse-phenotype-1.png we see that the "Software Engineering" Dimension has two values, one around 30 and the other around 100. It might be that the dimensions leave points to drag when a 5th is removed, or that adding a new dimension does not add a point to drag. In order to debug this, we will need the actual steps to reproduce. @exoticDFT

I've added the Hacktoberfest tabel to this issue, if addressed via a PR it will be given credit for a Hacktoberfest point.

braingram added a commit to braingram/rse-phenotype that referenced this issue Oct 14, 2020
Reset values on length mismatch between labels and values in genData
@braingram
Copy link
Contributor

I was able to reproduce this by loading the page and deleting one of the dimensions. This left a 5th point on the graph. Also, adding a dimension produces a graph with a missing point on the last line. Checking if the length of values is unequal to the length of the labels (dimensions) in genData can identify the problem and resetting the values appears to fix the issue.

vsoch added a commit that referenced this issue Oct 14, 2020
fix issue #13: extra or missing graph points on dimension change
@vsoch
Copy link
Collaborator Author

vsoch commented Oct 14, 2020

Closed with #14. Thank you @braingram !

@vsoch vsoch closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants