-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Irregular English bank holidays missing from the LSE calender #84
Comments
First, than you very much for this. I pushed a new commit that includes all the closed dates you identified with unit tests. For the holidays that are skipped and open, I am not able yet to figure out how the Pandas library (which drives this package) can work for that. If you know how that would be great, otherwise at some point I may need to hard code the holidays so can force the skip. |
As one of these extra holidays is this coming Friday, it would be good to cut a release before then if possible. |
@rbubley v.1.3.4 has been published to PyPi with the fixes above. Note that the removal of holidays has not been implemented yet. |
@matthew-tomlinson I figured out how to make the skipped holidays show as open. So now everything you highlighted has been fixed and there is a test in the code to make sure it works. This is in the commit 04e94a1 and pushed to PyPi as v1.3.5 Thank you very much for all your work on this. |
Could you please account for the following occasions in which the LSE was either closed due to a one-off English bank holiday or open due to the removal of a regular bank holiday in compensation [1, 2].
This code includes all the dates on which ad-hoc holiday addition or removal is required:
Running the above gives the following output:
I note that you have already added the additional holidays on 2012-06-04 and 2012-06-05 for the Diamond Jubilee, but did not remove the corresonding spring bank holiday on 2012-05-28.
Thank you in advance.
The text was updated successfully, but these errors were encountered: