New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Update XLON calendars #166
Conversation
This looks right to me. However, the only material changes (I believe) are to the May Bank holiday going forward (2021 and later) and the May Bank holiday in 1995. Everything else looks to be just style changes, right? |
Running the test suite gives this result:
|
Yep - I see the same issue in the CI. Will sort it out. |
Also yes - most of the changes were style, but I liked the styling in pandas market calendars better than what we previously had. |
Right - the issue here is we have It was closed as per http://news.bbc.co.uk/2/hi/uk_news/376063.stm (eve of the 3rd millennium). Will add a fix. |
This now works for the special holidays that started this PR, but it does appear that many of the old tests fail now |
Yep - forgot to fix the CSV. Doing that now. |
Updates XLON to include holidays from
pandas_market_calendars
.Closes #163.
See details from original PR: rsheftel/pandas_market_calendars#84