Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual legends and Dactyl Manuform #27

Merged
merged 9 commits into from
Mar 17, 2020
Merged

Conversation

ihatemyisp
Copy link
Contributor

  1. Adds the ability to have both top and front legends. It still allows for one or the other as well.
  2. Adds Dactyl Manuform layout (4x6 is the version I have made, but it can be scaled to the other sizes).

Dual legends

Initial commit of Dactyl Manuform 4x6 layout
Adding layout for legends on Dactyl Manuform 4x6
Adds support for adding front and top legends
Showing off dual legends
@rsheldiii
Copy link
Owner

This looks great, thanks for submitting! I'll get to this soon

Copy link
Owner

@rsheldiii rsheldiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks for submitting! Just a couple small things and it'll be perfect. looks like I gave you conflicts again :/ let me know if you want me to finish this up, I've definitely made it a little harder for you

src/settings.scad Outdated Show resolved Hide resolved
src/key_transformations.scad Outdated Show resolved Hide resolved
@ihatemyisp
Copy link
Contributor Author

Good to go @rsheldiii

I will say though I'm getting warnings (not sure if they were present prior to this round of edits) but everything works. I'm not really sure where to start with knocking them out.

5 duplicates:
WARNING: len() parameter could not be converted, in file src/libraries/scad-utils/trajectory.scad, line 7

@rsheldiii
Copy link
Owner

Thanks!

those warnings are caused by a code change in OpenSCAD - I think it used to be that calling len() on a non-list would result in undef, which you could use to determine if an argument is a list or not, but now it also results in a warning. The library still does what it's supposed to so it's safe to ignore for now, but it would be nice if I could figure out how to get rid of it

@rsheldiii rsheldiii merged commit 19abd52 into rsheldiii:master Mar 17, 2020
@mr-september
Copy link

@ihatemyisp thank you so much for this! I've been searching everywhere for an example of a dactyl(-like) layout with different top and front legends, just like your preview photo.

May I ask, what is the simplest way to get something like that photo, from where I can continue customizing legend and rows x columns from? Do you have any example/template?

@ihatemyisp
Copy link
Contributor Author

@mr-september If you take a look in https://github.com/rsheldiii/KeyV2/blob/master/src/layouts/dactyl_manuform/4x6_legends.scad you'll find all the legends and keysizes for the 4x6 manuform.

I will admit I haven't touched this or my dactyl in a long time so I'm not sure how well this will work with all the changes @rsheldiii has commited since this was pulled in. One thing I know for sure is that you'll want to change the thumb keys from 1.25 to 1 in r_thumb and l_thumb as 1.25u keycaps don't fit.

@mr-september
Copy link

mr-september commented May 30, 2022

@ihatemyisp thanks! So I'm sorta hacking it by editting 4x6_legends.scad itself (local version on my pc), and then just call dactyl_manuform_4x6_legends("dsa") key(); in keys.scad, is this the 'correct' way to do things?

Or can I adjust stuff in keys.scad itself? For example, switching to chocs stem?

@ihatemyisp
Copy link
Contributor Author

@ihatemyisp thanks! So I'm sorta hacking it by editting 4x6_legends.scad itself (local version on my pc), and then just call dactyl_manuform_4x6_legends("dsa") key(); in keys.scad, is this the 'correct' way to do things?

Or can I adjust stuff in keys.scad itself? For example, switching to chocs stem?

I'm honestly not sure if you can override the legends in keys.scad but you can adjust the stems.

To get choc stems it'd be dactyl_manuform_4x6_legends ("dsa") choc() key();. You'll get a warning about the choc stems being experimental (and from a printing standpoint, they'll likely be very prone to breakage).

If you plan to share your edits, it's best to create a copy of the entire dactyl_manform folder, rename the copied files and folder, and all the functions and then edit src\key_layouts.scad to include them.

@mr-september
Copy link

mr-september commented Jun 1, 2022

@ihatemyisp thank you for all the help! I am getting pretty close now! Is it possible (easy) to make all the keys the same height, rather than have the top row be really tall and curved inwards?

EDIT: Apologies, seems it's an overall bug with DSA, not specific to your layout, as discussed in #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants