Skip to content

Commit

Permalink
[Discover] Unskip ES|QL Inspector tests (elastic#183894)
Browse files Browse the repository at this point in the history
  • Loading branch information
jughosta authored and rshen91 committed May 29, 2024
1 parent 1a8186d commit 544aa2c
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 10 deletions.
23 changes: 17 additions & 6 deletions test/functional/apps/discover/group4/_esql_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -257,21 +257,32 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/183847
describe.skip('inspector', () => {
describe('inspector', () => {
beforeEach(async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
});

it('shows Discover and Lens requests in Inspector', async () => {
await PageObjects.discover.selectTextBaseLang();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
await inspector.open();
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
let retries = 0;
await retry.try(async () => {
if (retries > 0) {
await inspector.close();
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
}
await inspector.open();
retries = retries + 1;
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
});
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,16 +261,28 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
beforeEach(async () => {
await PageObjects.common.navigateToApp('discover');
await PageObjects.timePicker.setDefaultAbsoluteRange();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
});

it('shows Discover and Lens requests in Inspector', async () => {
await PageObjects.discover.selectTextBaseLang();
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
await inspector.open();
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
let retries = 0;
await retry.try(async () => {
if (retries > 0) {
await inspector.close();
await testSubjects.click('querySubmitButton');
await PageObjects.header.waitUntilLoadingHasFinished();
await PageObjects.discover.waitUntilSearchingHasFinished();
}
await inspector.open();
retries = retries + 1;
const requestNames = await inspector.getRequestNames();
expect(requestNames).to.contain('Table');
expect(requestNames).to.contain('Visualization');
});
});
});

Expand Down

0 comments on commit 544aa2c

Please sign in to comment.