-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs(update): Add contributing and update readme
- Loading branch information
1 parent
29ea612
commit 56032bb
Showing
2 changed files
with
84 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# Contributing Guidelines | ||
|
||
Some basic conventions for contributing to this project. | ||
|
||
### General | ||
|
||
Please make sure that there aren't existing pull requests attempting to address the issue mentioned. Likewise, please check for issues related to update, as someone else may be working on the issue in a branch or fork. | ||
|
||
* Non-trivial changes should be discussed in an issue first | ||
* Develop in a topic branch, not master | ||
* Squash your commits | ||
|
||
### Linting | ||
|
||
Please check your code using `npm run lint` before submitting your pull requests, as the CI build will fail if `eslint` fails. | ||
|
||
### Commit Message Format | ||
|
||
Each commit message should include a **type**, a **scope** and a **subject**: | ||
|
||
``` | ||
<type>(<scope>): <subject> | ||
``` | ||
|
||
Lines should not exceed 100 characters. This allows the message to be easier to read on github as well as in various git tools and produces a nice, neat commit log ie: | ||
|
||
``` | ||
#271 feat(standard): add style config and refactor to match | ||
#270 fix(config): only override publicPath when served by webpack | ||
#269 feat(eslint-config-defaults): replace eslint-config-airbnb | ||
#268 feat(config): allow user to configure webpack stats output | ||
``` | ||
|
||
#### Type | ||
|
||
Must be one of the following: | ||
|
||
* **feat**: A new feature | ||
* **fix**: A bug fix | ||
* **docs**: Documentation only changes | ||
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing | ||
semi-colons, etc) | ||
* **refactor**: A code change that neither fixes a bug or adds a feature | ||
* **test**: Adding missing tests | ||
* **chore**: Changes to the build process or auxiliary tools and libraries such as documentation | ||
generation | ||
|
||
#### Scope | ||
|
||
The scope could be anything specifying place of the commit change. For example `webpack`, | ||
`babel`, `redux` etc... | ||
|
||
#### Subject | ||
|
||
The subject contains succinct description of the change: | ||
|
||
* use the imperative, present tense: "change" not "changed" nor "changes" | ||
* don't capitalize first letter | ||
* no dot (.) at the end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters