Convert version numbers from Integer to String #1896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer rails/rails#36439 https://github.com/rails/rails/blob/aae270de9e0862f31b14642908472d235a17936f/activerecord/lib/active_record/schema_migration.rb#L47-L49 Here `all_versions` returns version numbers as an array of Integer, while Oracle enhanced adapter expects them as an array of String. ```ruby def all_versions order(:version).pluck(:version).map(&:to_i) end ``` Fix rsim#1893
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 20, 2019
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 20, 2019
yahonda
added a commit
to yahonda/oracle-enhanced
that referenced
this pull request
Jun 20, 2019
|
This pull request may be going to be unnecessary because of rails/rails#36525. |
|
Closing this pull request because it has been addressed by rails/rails#36525. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix #1893
rails/rails#36439 introduces the change below.
https://github.com/rails/rails/blob/aae270de9e0862f31b14642908472d235a17936f/activerecord/lib/active_record/schema_migration.rb#L47-L49
Here
all_versionsreturns version numbers as an array of Integer, while Oracle enhanced adapter expects them as an array of String.This pull request has a workaround commit to specify the commit has of Rails because Oracle enhanced adapter does not support rails/rails#35891 yet. This commit will be reverted later.