Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jeweler from gemspec and remove version constraint from jeweler i... #294

Merged
merged 2 commits into from
Aug 14, 2013

Conversation

unclebilly
Copy link
Contributor

bundle update is not working on a fresh checkout of the repo because of a version conflict between bundler and jeweler:

~/workspace/oracle-enhanced $ bundle
Fetching gem metadata from http://rubygems.org/.......
Fetching gem metadata from http://rubygems.org/..
Resolving dependencies...
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    jeweler (~> 1.5.1) ruby depends on
      bundler (~> 1.0.0) ruby

  Current Bundler version:
    bundler (1.3.0)

This Gemfile requires a different version of Bundler.
Perhaps you need to update Bundler by running `gem install bundler`?

This commit gets bundle working again by removing the version constraint on jeweler from the Gemfile. It also removes jeweler from the gemspec (it is unnecessary there).

@yahonda
Copy link
Collaborator

yahonda commented Mar 11, 2013

Thanks for the pull request. Since current oracle enhanced adapter supports from Rails 2.3 to Rails 3.2. Does this commit work for all versions?

@unclebilly
Copy link
Contributor Author

@yahonda The jeweler gem is used for managing and releasing gems. It should not be included in the gemspec as a dependency because the adapter does not depend on it to function. It should remain in the Gemfile under the development section if you guys choose to use it for building and deploying the gem. I did test bundle after making this change, and it worked ok.

@yahonda
Copy link
Collaborator

yahonda commented Mar 11, 2013

Thanks for the explanation. It looks make sense to me. @rsim @ebeigarts Any ideas?

@rsim
Copy link
Owner

rsim commented Mar 11, 2013

jeweler gem should be updated to latest version that is compatible with latest bundler and in Gemfile this latest version should be specified.

But it should not be removed from gemspec - currently gemspec is generated by jeweler and it is listing itself as development dependency and not runtime (see rubygems version check in generated gemspec).

@unclebilly
Copy link
Contributor Author

I restored jeweler in the gemspec and added a version declaration of ~> 1.8, which gets bundle working again.

yahonda added a commit that referenced this pull request Aug 14, 2013
Remove jeweler from gemspec and remove version constraint from jeweler i...
@yahonda yahonda merged commit 94d0b86 into rsim:master Aug 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants