Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove web3modal local variable dependency #244

Merged
merged 4 commits into from
Mar 21, 2022
Merged

fix: remove web3modal local variable dependency #244

merged 4 commits into from
Mar 21, 2022

Conversation

lucachaco
Copy link
Contributor

@lucachaco lucachaco commented Mar 17, 2022 •
edited
Loading

Now web3modal local storage WEB3_CONNECT_CACHED_PROVIDER is ignored

@lucachaco lucachaco marked this pull request as ready for review March 17, 2022 21:55
@ilanolkies ilanolkies merged commit 49ba459 into develop Mar 21, 2022
@ilanolkies ilanolkies linked an issue Mar 21, 2022 that may be closed by this pull request
Resolve web3modal migraiton issues to rLogin within rLogin #229
Closed
@jessgusclark
Copy link
Member

jessgusclark commented Mar 21, 2022 •
edited
Loading

@ilanolkies @lucachaco

There is still two references to the old variable that should be cleaned up:

  1. https://github.com/rsksmart/rLogin/blob/develop/src/lib/providerDisconnect.ts#L16

edit: removed incorrect reference

@jessgusclark jessgusclark mentioned this pull request Mar 21, 2022
Closed
@ilanolkies ilanolkies mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilanolkies ilanolkies ilanolkies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve web3modal migraiton issues to rLogin within rLogin
3 participants
@lucachaco @jessgusclark @ilanolkies