Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add scripts to manage collector tokens #125

Merged
merged 7 commits into from
Feb 27, 2023
Merged

feat: add scripts to manage collector tokens #125

merged 7 commits into from
Feb 27, 2023

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Feb 23, 2023 •
edited
Loading

What

  • create a hardhat task to add token to the collector
  • create a hardhat task to get tokens from the collector
  • create a hardhat task to remove tokens from the collector

Why

  • they are required to manage the collector

Refs

@antomor antomor self-assigned this Feb 23, 2023
@antomor antomor added the enhancement New feature or request label Feb 23, 2023
@antomor antomor requested a review from a team February 23, 2023 16:57
@antomor antomor marked this pull request as ready for review February 23, 2023 17:41
ironFe93
ironFe93 approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, comments are related to wording only.

test/tasks/collector/getTokens.test.ts Outdated Show resolved Hide resolved
test/tasks/collector/removeToken.test.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
hardhat.config.ts Outdated Show resolved Hide resolved
jurajpiar
jurajpiar requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests are not valid as the tested methods are stubbed.

@jurajpiar jurajpiar self-requested a review February 24, 2023 15:36
jurajpiar
jurajpiar approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

jurajpiar
jurajpiar approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@antomor antomor merged commit db853e9 into main Feb 27, 2023
@antomor antomor deleted the PP-687/add-scripts-to-manage-collector-tokens branch February 27, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 approved these changes

@jurajpiar jurajpiar jurajpiar approved these changes

Assignees

@antomor antomor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antomor @ironFe93 @jurajpiar