Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-163: Smartwallet tests #33

Merged
merged 14 commits into from
Aug 9, 2022
Merged

PP-163: Smartwallet tests #33

merged 14 commits into from
Aug 9, 2022

Conversation

jd-iov
Copy link
Collaborator

@jd-iov jd-iov commented Jun 15, 2022 •
edited
Loading

What

  • Tests for CustomSmartWallet and SmartWallet contracts

Why

  • Increase test coverage over these contracts by adding these unit tests

Refs

@antomor antomor changed the title Pp 163/smartwallet tests PP-163: Smartwallet tests Jul 29, 2022
franciscotobar
franciscotobar reviewed Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@franciscotobar franciscotobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TestUtils.ts is going to be individual for each project?

jurajpiar
jurajpiar reviewed Aug 3, 2022
View reviewed changes
test/utils/TestUtils.ts Outdated Show resolved Hide resolved
@antomor
Copy link
Collaborator

antomor commented Aug 3, 2022

The TestUtils.ts is going to be individual for each project?

It depends on its usage. If we notice we need it in other projects we could decide to export it from here or to create a utility library for testing.

jurajpiar
jurajpiar reviewed Aug 3, 2022
View reviewed changes
test/utils/TestUtils.ts Outdated Show resolved Hide resolved
jurajpiar
jurajpiar reviewed Aug 3, 2022
View reviewed changes
package.json Show resolved Hide resolved
jurajpiar
jurajpiar reviewed Aug 3, 2022
View reviewed changes
package.json Show resolved Hide resolved
jurajpiar
jurajpiar reviewed Aug 3, 2022
View reviewed changes
package.json Show resolved Hide resolved
@antomor antomor mentioned this pull request Aug 4, 2022
Merged
jurajpiar
jurajpiar reviewed Aug 8, 2022
View reviewed changes
test/utils.ts Outdated Show resolved Hide resolved
jurajpiar
jurajpiar approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@jurajpiar jurajpiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

AndresQuijano
AndresQuijano approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@AndresQuijano AndresQuijano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antomor @jurajpiar
Update test/utils.ts
92c7759 
Co-authored-by: Juraj <juraj.piar@icloud.com>
@antomor antomor merged commit bfef4d6 into rsksmart:master Aug 9, 2022
@antomor antomor deleted the PP-163/smartwallet-tests branch August 10, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor left review comments

@franciscotobar franciscotobar franciscotobar left review comments

@jurajpiar jurajpiar jurajpiar approved these changes

@AndresQuijano AndresQuijano AndresQuijano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jd-iov @antomor @jurajpiar @AndresQuijano @franciscotobar