Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-515: Add script to change partner shares #78

Merged
merged 5 commits into from
Oct 21, 2022
Merged

PP-515: Add script to change partner shares #78

merged 5 commits into from
Oct 21, 2022

Conversation

antomor
Copy link
Collaborator

@antomor antomor commented Oct 18, 2022

What

  • Add a utility script to be used to change the partner shares of a collector

Why

  • Without the script, we need to call directly the contract method, and it may be less user-friendly.

@antomor antomor requested review from a team and jd-iov October 18, 2022 10:41
franciscotobar
franciscotobar reviewed Oct 19, 2022
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
franciscotobar
franciscotobar reviewed Oct 19, 2022
View reviewed changes
Readme.md Outdated Show resolved Hide resolved
@franciscotobar
Copy link
Collaborator

Quick question, updating the partner shares, does not obligate to withdraw the funds, right?

antomor and others added 2 commits October 21, 2022 09:16
@antomor @franciscotobar
Update Readme.md
f6b0c59 
Co-authored-by: franciscotobar <100875069+franciscotobar@users.noreply.github.com>
@antomor @franciscotobar
Update Readme.md
a2ce458 
Co-authored-by: franciscotobar <100875069+franciscotobar@users.noreply.github.com>
@antomor
Copy link
Collaborator Author

antomor commented Oct 21, 2022

@franciscotobar thank you for the comments, I've updated the PR.

Quick question, updating the partner shares, does not obligate to withdraw the funds, right?

It's a pre-requirement, and indeed I specified it in the readme also, thank you for highlighting

@antomor antomor force-pushed the PP-515/add-script-to-change-partner-shares branch from 647317a to c13dbcf Compare October 21, 2022 08:03
ironFe93
ironFe93 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@ironFe93 ironFe93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

franciscotobar
franciscotobar approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@franciscotobar franciscotobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ironFe93 ironFe93 merged commit cb43c88 into master Oct 21, 2022
@antomor antomor deleted the PP-515/add-script-to-change-partner-shares branch October 28, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ironFe93 ironFe93 ironFe93 approved these changes

@franciscotobar franciscotobar franciscotobar approved these changes

@jd-iov jd-iov Awaiting requested review from jd-iov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antomor @franciscotobar @ironFe93