PP-510: script for removing tokens #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antomor
changed the title
antomor
requested changes
Oct 20, 2022
There was a problem hiding this comment.
@ironFe93 thank you for your changes, but I don't think that the script is going to work.
The getAcceptedTokens is a view function, so we should call it with call ( e.g.: const acceptedTokens = await smartWalletDeployVerifier.methods.getAcceptedTokens().call();), especially because if we use send we won't have the return values of the function called, but just the transaction receipt
await smartWalletDeployVerifier.methods.getAcceptedTokens().send({from: accounts[0]});
|
This PR depends on #80 |
|
@antomor it is done now |
…f 'allowTokens.js'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
script for removing tokens
Why
utility script
Refs