Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-509: add the removeToken method #80

Merged
merged 1 commit into from
Oct 20, 2022
Merged

PP-509: add the removeToken method #80

merged 1 commit into from
Oct 20, 2022

Conversation

ironFe93
Copy link
Contributor

@ironFe93 ironFe93 commented Oct 20, 2022 •
edited
Loading

What

method to remove tokens from acceptedTokens array

Why

Functionally there needs to exist a counterpart to acceptToken()

Refs

tests contained in:
#79

@ironFe93 ironFe93 requested a review from a team October 20, 2022 10:50
@ironFe93 ironFe93 self-assigned this Oct 20, 2022
@antomor antomor changed the title feat: removeToken method PP-509: add the removeToken method Oct 20, 2022
@antomor antomor mentioned this pull request Oct 20, 2022
Merged
antomor
antomor approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tests aren't included here because we decided to include them directly in the new version, see #79

@ironFe93 ironFe93 merged commit 75c792b into master Oct 20, 2022
@antomor antomor deleted the feature/PP-509/remove-token branch October 21, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

Assignees

@ironFe93 ironFe93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ironFe93 @antomor