PP-567 Migrate Withdraw Task #93

ironFe93 · 2022-11-16T14:49:49Z

What

Migrate withdraw task to hardhat version. Also includes reorganization of the repo and removal of unused files.

Why

to stick with the tooling that hardhat gives us

Refs

(optional: include links to other issues, PRs, tickets, etc)

ironFe93 · 2022-11-22T12:11:45Z

Needs to be rebased, waiting for #95 and #97

scripts/withdraw.ts

hardhat.config.ts

package.json

test/scripts/withdraw.test.ts

antomor

@ironFe93 Apart from the comments left, I'd also remove the file tasks/withdraw.js if not necessary.

package.json

scripts/withdraw.ts

hardhat.config.ts

scripts/withdraw.ts

test/scripts/withdraw.test.ts

antomor · 2022-11-25T08:06:02Z

Readme.md

@@ -44,38 +44,24 @@ The project is ready to be used at this point.
 The contracts can be deployed in the following way:

 1. Configure the `hardhat.config.ts` file on the root of the project to set your network 
-2. Run `npm run deploy <NETWORK_NAME>` 
+2. Run `npx run deploy --network <NETWORK_NAME>` 


shouldn't this be

Suggested change

2. Run `npx run deploy --network <NETWORK_NAME>`

2. Run `npx hardhat deploy --network <NETWORK_NAME>`

antomor · 2022-11-25T08:06:53Z

deploy-collector.input.sample.json

@@ -1,23 +0,0 @@
-{


I wouldn't remove this sample file, because it may simplify the usage.

this was removed by mistake

antomor · 2022-11-25T08:07:13Z

hardhat.config.ts

@@ -105,6 +106,14 @@ task('allowed-tokens', 'Retrieves a list of allowed tokens')
    await getAllowedTokens(hre);
  }
 );
+task('collector:withdraw', 'Withdraws funds from a collector contract')


I'd include an empty line before

* feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org>

feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 chore: re-adds contracts chore: adds dev rules chore(contracts): fixes solidity lint errors chore(test): re-adds tests chore(upgrade): adds deployment tools chore(upgrade): add smock for contract mocking chore(upgrade): removes sol tests chore(upgrade): fixe pre-commit and update readme chore(upgrade): add more eslint rules chore(deps): move typechain to deps chore(upgrade): unignore dist from npm i chore(ethers): return util token for manual testing 👿 PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * refactor: migrate the removeTokens script to use Hardhat and Ethers.js * fix: fix the task in hardhat.config, update Readme and apply format Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-566: migrate script deploy collector (#95) * feat: dummy commit, create empty deployCollector.ts file * refactor: add script and task to deploy a Collector using Hardhat and Ethers.js * style: apply format rules * test: add the tests, remove the positional arguments and simplify the output file * fix: apply PR suggestions Remove some scripts from the package.json Use console.table to print the collector output Rename the input config file parameter Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * refactor: prettier fix: fix the collector and add the missing tests Fix the collector updateRemainderAddress Include the missing test for the stakeForAddress method fix: add config to use custom signers to run scripts (#106) feat: expiration mechanism (#105) * feat: expiration mechanism * fix: FWD to SW * feat: validate time on deploy Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * chore: rename .prettierrc to prettier.json5 to be consistent among all the repos PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org>

* chore(ethers): change to ethers and updgrade dependencies feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 chore: re-adds contracts chore: adds dev rules chore(contracts): fixes solidity lint errors chore(test): re-adds tests chore(upgrade): adds deployment tools chore(upgrade): add smock for contract mocking chore(upgrade): removes sol tests chore(upgrade): fixe pre-commit and update readme chore(upgrade): add more eslint rules chore(deps): move typechain to deps chore(upgrade): unignore dist from npm i chore(ethers): return util token for manual testing 👿 PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * refactor: migrate the removeTokens script to use Hardhat and Ethers.js * fix: fix the task in hardhat.config, update Readme and apply format Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-566: migrate script deploy collector (#95) * feat: dummy commit, create empty deployCollector.ts file * refactor: add script and task to deploy a Collector using Hardhat and Ethers.js * style: apply format rules * test: add the tests, remove the positional arguments and simplify the output file * fix: apply PR suggestions Remove some scripts from the package.json Use console.table to print the collector output Rename the input config file parameter Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * refactor: prettier fix: fix the collector and add the missing tests Fix the collector updateRemainderAddress Include the missing test for the stakeForAddress method fix: add config to use custom signers to run scripts (#106) feat: expiration mechanism (#105) * feat: expiration mechanism * fix: FWD to SW * feat: validate time on deploy Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * chore: rename .prettierrc to prettier.json5 to be consistent among all the repos PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> * fix: apply format and lint rules --------- Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> Co-authored-by: Antonio Morrone <antonio@iovlabs.org>

feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 * PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * fix: fix the task in hardhat.config, update Readme and apply format * PP-566: migrate script deploy collector (#95) * test: add the tests, remove the positional arguments and simplify the output file * Rename the input config file parameter * PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * fix: remove the script from package.json and update Readme.md * PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * feat: complete withdrawal task and tests * fix: no from parameter on withdraw * feat: reorganize tasks and tests * fix: restore .prepare script * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file * PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * fix: fix the collector and add the missing tests * Fix the collector updateRemainderAddress * Include the missing test for the stakeForAddress method * fix: add config to use custom signers to run scripts (#106) * feat: expiration mechanism (#105) * feat: expiration mechanism * feat: validate time on deploy * PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow * PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme * 2.0.0-beta.0 * fix: replace master with main on codeql workflow (#116) * fix: comment the NativeHolderSmartWallet unit tests and fix IForwarder --------- Co-authored-by: Antonio Morrone <antonio@iovlabs.org> Co-authored-by: Juraj <juraj.piar@icloud.com> Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local>

ironFe93 changed the title ~~feat: new hardhat task~~ PP-567 Migrate Withdraw Task Nov 18, 2022

ironFe93 force-pushed the feature/PP-567/migrate-withdraw-task branch from f32355f to 0489164 Compare November 22, 2022 12:10

ironFe93 marked this pull request as ready for review November 22, 2022 12:12

antomor assigned ironFe93 Nov 22, 2022

antomor requested a review from a team November 22, 2022 22:18

AndresQuijano reviewed Nov 23, 2022

View reviewed changes

scripts/withdraw.ts Outdated Show resolved Hide resolved

AndresQuijano reviewed Nov 24, 2022

View reviewed changes

hardhat.config.ts Outdated Show resolved Hide resolved

AndresQuijano reviewed Nov 24, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

AndresQuijano reviewed Nov 24, 2022

View reviewed changes

test/scripts/withdraw.test.ts Outdated Show resolved Hide resolved

antomor requested changes Nov 24, 2022

View reviewed changes

ironFe93 force-pushed the feature/PP-567/migrate-withdraw-task branch from d1d64b8 to 0ac206f Compare November 24, 2022 13:58

Christos Otarola and others added 7 commits November 24, 2022 09:05

feat: new hardhat task

7224c57

feat: create withdraw task

f9eb487

chore: update readme

5fe769a

feat: complete withdrawal task and tests

9e4443d

chore: linted

2eb4aab

fix: no from parameter on withdraw

4d5d1be

chore: change readme, description of task

09b5274

ironFe93 force-pushed the feature/PP-567/migrate-withdraw-task branch from 0ac206f to 09b5274 Compare November 24, 2022 14:09

Christos Otarola added 7 commits November 24, 2022 10:20

feat: reorganize tasks and tests

b96dee2

fix: restore .prepare script

375bb8b

fix: typo on script

cdf078f

fix: restore file permissions

09a625a

fix: prettier issues, no waffle json file

2983dfc

fix: no prepare task

0f1f8cb

chore: remove unneeded rules

4b828c5

antomor requested changes Nov 25, 2022

View reviewed changes

antomor added 2 commits November 25, 2022 09:57

fix: change Readme.md to fix the command instruction

26e178f

fix: restore the collector:deploy sample config file

9368e42

ironFe93 merged commit 8746dfa into feature/PP-278/PP-329/upgrade_contracts Nov 25, 2022

antomor deleted the feature/PP-567/migrate-withdraw-task branch January 5, 2023 09:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PP-567 Migrate Withdraw Task #93

PP-567 Migrate Withdraw Task #93

ironFe93 commented Nov 16, 2022 •

edited

Loading

ironFe93 commented Nov 22, 2022 •

edited

Loading

antomor left a comment

antomor Nov 25, 2022

antomor Nov 25, 2022

ironFe93 Nov 25, 2022

antomor Nov 25, 2022

	2. Run `npx run deploy --network <NETWORK_NAME>`
	2. Run `npx hardhat deploy --network <NETWORK_NAME>`

PP-567 Migrate Withdraw Task #93

PP-567 Migrate Withdraw Task #93

Conversation

ironFe93 commented Nov 16, 2022 • edited Loading

What

Why

Refs

ironFe93 commented Nov 22, 2022 • edited Loading

antomor left a comment

Choose a reason for hiding this comment

antomor Nov 25, 2022

Choose a reason for hiding this comment

antomor Nov 25, 2022

Choose a reason for hiding this comment

ironFe93 Nov 25, 2022

Choose a reason for hiding this comment

antomor Nov 25, 2022

Choose a reason for hiding this comment

ironFe93 commented Nov 16, 2022 •

edited

Loading

ironFe93 commented Nov 22, 2022 •

edited

Loading