PP-569: migrate change partners #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antomor
changed the title
|
Although the PR should be ready, this PR depends on #95. |
ironFe93
reviewed
Nov 21, 2022
| task('change-partner-shares', 'Change partner shares of a collector') | ||
| .addParam('collectorAddress', 'address of the collector we want to modify') | ||
| .addParam('partnerConfig', 'path of the file that includes the partner shares configuration') | ||
| .addOptionalParam('gasLimit', 'gasLimit to be used for the transaction') |
jurajpiar
reviewed
Nov 21, 2022
jurajpiar
reviewed
Nov 21, 2022
ironFe93
approved these changes
Nov 21, 2022
ironFe93
reviewed
Nov 22, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit 76ee863.
antomor
force-pushed
the
PP-569/migrate-change-partners
branch
from
647c7f3
to
9b4a724
Compare
antomor
added a commit
that referenced
this pull request
Nov 30, 2022
* chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules
antomor
pushed a commit
that referenced
this pull request
Jan 26, 2023
feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 chore: re-adds contracts chore: adds dev rules chore(contracts): fixes solidity lint errors chore(test): re-adds tests chore(upgrade): adds deployment tools chore(upgrade): add smock for contract mocking chore(upgrade): removes sol tests chore(upgrade): fixe pre-commit and update readme chore(upgrade): add more eslint rules chore(deps): move typechain to deps chore(upgrade): unignore dist from npm i chore(ethers): return util token for manual testing 👿 PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * refactor: migrate the removeTokens script to use Hardhat and Ethers.js * fix: fix the task in hardhat.config, update Readme and apply format Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-566: migrate script deploy collector (#95) * feat: dummy commit, create empty deployCollector.ts file * refactor: add script and task to deploy a Collector using Hardhat and Ethers.js * style: apply format rules * test: add the tests, remove the positional arguments and simplify the output file * fix: apply PR suggestions Remove some scripts from the package.json Use console.table to print the collector output Rename the input config file parameter Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * refactor: prettier fix: fix the collector and add the missing tests Fix the collector updateRemainderAddress Include the missing test for the stakeForAddress method fix: add config to use custom signers to run scripts (#106) feat: expiration mechanism (#105) * feat: expiration mechanism * fix: FWD to SW * feat: validate time on deploy Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * chore: rename .prettierrc to prettier.json5 to be consistent among all the repos PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org>
antomor
pushed a commit
that referenced
this pull request
Jan 26, 2023
feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 chore: re-adds contracts chore: adds dev rules chore(contracts): fixes solidity lint errors chore(test): re-adds tests chore(upgrade): adds deployment tools chore(upgrade): add smock for contract mocking chore(upgrade): removes sol tests chore(upgrade): fixe pre-commit and update readme chore(upgrade): add more eslint rules chore(deps): move typechain to deps chore(upgrade): unignore dist from npm i chore(ethers): return util token for manual testing 👿 PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * refactor: migrate the removeTokens script to use Hardhat and Ethers.js * fix: fix the task in hardhat.config, update Readme and apply format Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-566: migrate script deploy collector (#95) * feat: dummy commit, create empty deployCollector.ts file * refactor: add script and task to deploy a Collector using Hardhat and Ethers.js * style: apply format rules * test: add the tests, remove the positional arguments and simplify the output file * fix: apply PR suggestions Remove some scripts from the package.json Use console.table to print the collector output Rename the input config file parameter Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * refactor: prettier fix: fix the collector and add the missing tests Fix the collector updateRemainderAddress Include the missing test for the stakeForAddress method fix: add config to use custom signers to run scripts (#106) feat: expiration mechanism (#105) * feat: expiration mechanism * fix: FWD to SW * feat: validate time on deploy Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * chore: rename .prettierrc to prettier.json5 to be consistent among all the repos PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org>
antomor
added a commit
that referenced
this pull request
Jan 27, 2023
* chore(ethers): change to ethers and updgrade dependencies feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 chore: re-adds contracts chore: adds dev rules chore(contracts): fixes solidity lint errors chore(test): re-adds tests chore(upgrade): adds deployment tools chore(upgrade): add smock for contract mocking chore(upgrade): removes sol tests chore(upgrade): fixe pre-commit and update readme chore(upgrade): add more eslint rules chore(deps): move typechain to deps chore(upgrade): unignore dist from npm i chore(ethers): return util token for manual testing 👿 PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * refactor: migrate the removeTokens script to use Hardhat and Ethers.js * fix: fix the task in hardhat.config, update Readme and apply format Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-566: migrate script deploy collector (#95) * feat: dummy commit, create empty deployCollector.ts file * refactor: add script and task to deploy a Collector using Hardhat and Ethers.js * style: apply format rules * test: add the tests, remove the positional arguments and simplify the output file * fix: apply PR suggestions Remove some scripts from the package.json Use console.table to print the collector output Rename the input config file parameter Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * refactor: prettier fix: fix the collector and add the missing tests Fix the collector updateRemainderAddress Include the missing test for the stakeForAddress method fix: add config to use custom signers to run scripts (#106) feat: expiration mechanism (#105) * feat: expiration mechanism * fix: FWD to SW * feat: validate time on deploy Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * chore: rename .prettierrc to prettier.json5 to be consistent among all the repos PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> * fix: apply format and lint rules --------- Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> Co-authored-by: Antonio Morrone <antonio@iovlabs.org>
antomor
added a commit
that referenced
this pull request
Feb 3, 2023
* chore(ethers): change to ethers and updgrade dependencies feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 chore: re-adds contracts chore: adds dev rules chore(contracts): fixes solidity lint errors chore(test): re-adds tests chore(upgrade): adds deployment tools chore(upgrade): add smock for contract mocking chore(upgrade): removes sol tests chore(upgrade): fixe pre-commit and update readme chore(upgrade): add more eslint rules chore(deps): move typechain to deps chore(upgrade): unignore dist from npm i chore(ethers): return util token for manual testing 👿 PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * refactor: migrate the removeTokens script to use Hardhat and Ethers.js * fix: fix the task in hardhat.config, update Readme and apply format Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-566: migrate script deploy collector (#95) * feat: dummy commit, create empty deployCollector.ts file * refactor: add script and task to deploy a Collector using Hardhat and Ethers.js * style: apply format rules * test: add the tests, remove the positional arguments and simplify the output file * fix: apply PR suggestions Remove some scripts from the package.json Use console.table to print the collector output Rename the input config file parameter Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * Revert "style: include automatically formatted solidity files" This reverts commit 76ee863. * fix: remove the script from package.json and update Readme.md * style: apply formatting rules PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * chore: update readme * feat: complete withdrawal task and tests * chore: linted * fix: no from parameter on withdraw * chore: change readme, description of task * feat: reorganize tasks and tests * fix: restore .prepare script * fix: typo on script * fix: restore file permissions * fix: prettier issues, no waffle json file * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> Co-authored-by: Antonio Morrone <antonio@iovlabs.org> PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * refactor: prettier fix: fix the collector and add the missing tests Fix the collector updateRemainderAddress Include the missing test for the stakeForAddress method fix: add config to use custom signers to run scripts (#106) feat: expiration mechanism (#105) * feat: expiration mechanism * fix: FWD to SW * feat: validate time on deploy Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local> PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * chore: rename .prettierrc to prettier.json5 to be consistent among all the repos PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> * fix: apply format and lint rules --------- Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> Co-authored-by: Antonio Morrone <antonio@iovlabs.org>
antomor
added a commit
that referenced
this pull request
Feb 6, 2023
feat(upgrade): re-create project with hardhat & ethers removing truffle and web3 * PP-565: migrate the removeTokens script to use Hardhat and Ethers.js (#92) * fix: fix the task in hardhat.config, update Readme and apply format * PP-566: migrate script deploy collector (#95) * test: add the tests, remove the positional arguments and simplify the output file * Rename the input config file parameter * PP-569: migrate change partners (#97) * chore: change package.json version * feat: migrate the change-partners script to use ether.js * fix: change the parseJsonFile function to return undefined * fix: apply PR suggestions * fix: remove the script from package.json and update Readme.md * PP-567 Migrate Withdraw Task (#93) * feat: new hardhat task * feat: create withdraw task * feat: complete withdrawal task and tests * fix: no from parameter on withdraw * feat: reorganize tasks and tests * fix: restore .prepare script * fix: no prepare task * chore: remove unneeded rules * fix: change Readme.md to fix the command instruction * fix: restore the collector:deploy sample config file * PP-355/update-rif-relay-server (#96) * refactor(index): expose typing for relay-server * fix: fix the collector and add the missing tests * Fix the collector updateRemainderAddress * Include the missing test for the stakeForAddress method * fix: add config to use custom signers to run scripts (#106) * feat: expiration mechanism (#105) * feat: expiration mechanism * feat: validate time on deploy * PP-602/RelayClient: _validateSmartWallet (#109) * refactor(SmartWallet): expose getOwner * refactor(index): expose PromiseOrValue * chore: github workflow * PP-358: include the contracts in dist (#112) * fix: remove contracts from npmignore * PP-357: Add a task to mint utility tokens (#113) * feat: add a task to mint utility tokens * fix: apply linting and format to tasks * refactor: expose RelayHubInterface * docs: readme * 2.0.0-beta.0 * fix: replace master with main on codeql workflow (#116) * fix: comment the NativeHolderSmartWallet unit tests and fix IForwarder --------- Co-authored-by: Antonio Morrone <antonio@iovlabs.org> Co-authored-by: Juraj <juraj.piar@icloud.com> Co-authored-by: Francisco Tobar <francisco.tobar@iovlabs.org> Co-authored-by: Christos Otarola <christos@Christoss-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why