Fix lint and test

src/controller/httpsAPI.ts

@@ -72,25 +72,25 @@ export class HttpsAPI {
         * and to or from params should be our address when we send or receive a cryptocurrency
         * (such as RBTC).
         */
-        const transactions: {data: IApiTransactions[], prev: string, next: string} = 
+        const transactions: {data: IApiTransactions[], prev: string, next: string} =
         await dataSource.getTransactionsByAddress(address, limit as string,
           prev as string, next as string, blockNumber as string)
-        .catch(( () => {[]} ))
+          .catch(nextFunction)
         /* We query events to find transactions when we send or receive a token(ERC20)
         * such as RIF,RDOC
         * Additionally, we query internal transactions because we could send or receive a cryptocurrency
         * invoking a smart contract.
         * Finally, we filter by blocknumber and duplicates
         */
-        const hashes: string[] = await Promise.all([dataSource.getEventsByAddress(address, limit as string), 
+        const hashes: string[] = await Promise.all([dataSource.getEventsByAddress(address, limit as string),
           dataSource.getInternalTransactionByAddress(address, limit as string)])
-          .then((promises) => 
+          .then((promises) =>
             promises.flat()
-            .filter((value: IEvent | IInternalTransaction) => 
-              isMyTransaction(value, address) && value.blockNumber >= + blockNumber)
-            .filter((value: IEvent | IInternalTransaction) => !transactions.data.map(tx => tx.hash)
-              .includes(value.transactionHash))
-            .map((value: IEvent | IInternalTransaction) => value.transactionHash)
+              .filter((value: IEvent | IInternalTransaction) =>
+                isMyTransaction(value, address) && value.blockNumber >= +blockNumber)
+              .filter((value: IEvent | IInternalTransaction) => !transactions.data.map(tx => tx.hash)
+                .includes(value.transactionHash))
+              .map((value: IEvent | IInternalTransaction) => value.transactionHash)
           )
           .then((hashes: string[]) => Array.from(new Set(hashes)))
           .catch(() => [])
@@ -102,8 +102,8 @@ export class HttpsAPI {
           next: transactions.next,
           data: [...transactions.data, ...result]
         })
-        .then(this.responseJsonOk(res))
-        .catch(nextFunction)
+          .then(this.responseJsonOk(res))
+          .catch(nextFunction)
       }
 
     )

src/service/transaction/transactionProvider.ts

@@ -1,5 +1,4 @@
 import { DataSource } from '../../repository/DataSource'
-import { IEvent } from '../../rskExplorerApi/types'
 import type { Event } from '../../types/event'
 import { PollingProvider } from '../AbstractPollingProvider'
 import { isMyTransaction } from './utils'
@@ -17,18 +16,16 @@ export class TransactionProvider extends PollingProvider<Event> {
       this.dataSource.getEventsByAddress(this.address.toLowerCase()),
       this.dataSource.getInternalTransactionByAddress(this.address.toLowerCase())
     ])
-    .then(promises => 
+      .then(promises =>
         promises.flat()
-        .filter(transaction => isMyTransaction(transaction, address))
-        .map(transaction => transaction.transactionHash)
-    )
-    .then((hashes: string[]) => Array.from(new Set(hashes)))
-    .catch(() => [])
+          .filter(transaction => isMyTransaction(transaction, address))
+          .map(transaction => transaction.transactionHash)
+      )
+      .then((hashes: string[]) => Array.from(new Set(hashes)))
+      .catch(() => [])
 
-
     return await Promise.all(hashes
       .map(hash => this.dataSource.getTransaction(hash)))
-
   }
 
   async getTransactionsPaginated (address: string, limit?: string, prev?: string, next?: string) {

src/service/transaction/utils.ts

@@ -1,11 +1,11 @@
 import { IEvent, IInternalTransaction } from '../../rskExplorerApi/types'
 
 export function isMyTransaction (event: IEvent | IInternalTransaction, address: string) {
-  if("args" in event) {
+  if ('args' in event) {
     return event.args.some((arg) => arg.toLowerCase() === address.toLowerCase())
   }
-  if("action" in event) {
-    return event.action.from.toLowerCase() === address.toLowerCase() 
-      || event.action.to.toLowerCase() === address.toLowerCase()
+  if ('action' in event) {
+    return event.action.from.toLowerCase() === address.toLowerCase() ||
+      event.action.to.toLowerCase() === address.toLowerCase()
   }
 }

test/address.test.ts

@@ -26,11 +26,13 @@ const getEventsByAddressMock = jest.fn(() => Promise.resolve(eventResponse))
 const getTransactionsByAddressMock = jest.fn(() => Promise.resolve(transactionResponse))
 const getTokensByAddressMock = jest.fn(() => Promise.resolve(tokenResponse))
 const getTransactionMock = jest.fn(() => Promise.resolve(transactionFromEventResponse))
+const getInternalTransactionByAddressMock = jest.fn(() => Promise.resolve({data:[]}))
 const rskExplorerApiMock = {
   getEventsByAddress: getEventsByAddressMock,
   getTransactionsByAddress: getTransactionsByAddressMock,
   getTokensByAddress: getTokensByAddressMock,
-  getTransaction: getTransactionMock
+  getTransaction: getTransactionMock,
+  getInternalTransactionByAddress: getInternalTransactionByAddressMock
 } as any
 const dataSourceMapping = {}
 dataSourceMapping['31'] = rskExplorerApiMock