Live balances, transactions and prices #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chescalante
commented
Dec 14, 2021
•
chescalante
commented
- connect by address
- handle disconnect
- polling strategy for tokens
- push transactions
- (push tokens)
- polling strategy for prices
- cache for prices
…he coinmarketcap api
2 tasks
| @@ -3,6 +3,9 @@ import express, { Request, Response } from 'express' | |||
| import { Api } from './api' | |||
| import registeredDapps from './registered_dapps' | |||
| import { isValidAddress } from './utils' | |||
| import { Server } from 'socket.io' | |||
| import http from 'http' | |||
There was a problem hiding this comment.
Suggested change
| import http from 'http' | |
| import https from 'https' |
Lets make this safe
There was a problem hiding this comment.
I'll need a ssl certificate for that. (https://nodejs.org/en/knowledge/HTTP/servers/how-to-create-a-HTTPS-server/)
Let's do it in another PR.
There was a problem hiding this comment.
yes, definitely.
For dev you can use a self signed (self generated) for prod, you should cordinate that with devops
…the token is supported or not, since we are doing that inside the coinmarketcap function
…the token is supported or not, since we are doing that inside the coinmarketcap function
… if there are no addresses
…doesnt have any token yet, the backend wont crash because of the coinmarket cap api no receiving tokens ids
Feature/live prices
ilanolkies
requested changes
Jan 17, 2022
| id: params.addresses.map(address => addressToCoinmarketcapId[address]).join(','), | ||
| const fromQueryParamsToRequestParams = (params: PricesQueryParams, chaindId: number): ICoinMarketCapQuoteParams => ({ | ||
| id: params.addresses | ||
| .filter((address) => isTokenSupported(address, chaindId)) |
There was a problem hiding this comment.
Why this again? We should do decide where to do it and do it only once
| } | ||
| } | ||
|
|
||
| const executeFactory = ( |
There was a problem hiding this comment.
I guess we wan to declare the functions before we use them. Should we reorder this code?
ilanolkies
requested changes
Jan 21, 2022
* Custom error class and errorhandler functio * Removing errorhandler from here and using it in setupAPI * Uncommenting the asserts that checked the text of the error message response * Implementing next function in the error handlers of the promises * Update src/middleware/index.ts Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> * Update src/middleware/index.ts Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> * Update src/api/index.ts Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com> * applying suggestions Co-authored-by: Agustin Villalobos <agustin.villalobos@iovlabs.org> Co-authored-by: Ilan <36084092+ilanolkies@users.noreply.github.com>
Fix how transactions are selected to be pushed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.