Skip to content

Commit

Permalink
Don't close UDP channel on exception
Browse files Browse the repository at this point in the history
We don't need to close the channel because UDP is connection-less.

There was a comment stating this, but someone ignored it at some point
in the EthereumJ codebase: ethereum/ethereumj@65fd770#diff-364a0e29f783aa2c9c709bc8ae663b9dR60
  • Loading branch information
colltoaction committed Oct 19, 2018
1 parent 01d3986 commit f34374d
Showing 1 changed file with 0 additions and 1 deletion.
Expand Up @@ -64,7 +64,6 @@ public void channelReadComplete(ChannelHandlerContext ctx) {
@Override
public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
logger.debug("Discover channel error", cause);
ctx.close();
// We don't close the channel because we can keep serving requests.
}

Expand Down

0 comments on commit f34374d

Please sign in to comment.