-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented block propagation enhancements #1326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlopezrsk
reviewed
Oct 8, 2020
rskj-core/src/test/java/co/rsk/net/utils/AsyncNodeBlockProcessorListener.java
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
a6b60af
to
b7e58e7
Compare
ajlopezrsk
reviewed
Oct 21, 2020
patogallaiovlabs
requested changes
Oct 22, 2020
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
rskj-core/src/test/java/co/rsk/net/AsyncNodeBlockProcessorUnclesTest.java
Show resolved
Hide resolved
This case should be tested on integration tests 👍 |
pipeline: run |
donequis
suggested changes
Oct 29, 2020
36c31e5
to
d335ae9
Compare
ajlopezrsk
reviewed
Nov 18, 2020
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
d335ae9
to
aa36442
Compare
@ajlopez it looks like you're referring to some previous commit. Now the processing logic has changed a bit. Please check it out. |
pipeline: run |
aa36442
to
5af06a3
Compare
pipeline: run |
ajlopezrsk
previously approved these changes
Nov 25, 2020
donequis
reviewed
Nov 26, 2020
rskj-core/src/main/java/co/rsk/core/bc/BlockHeaderRelayValidatorImpl.java
Outdated
Show resolved
Hide resolved
donequis
reviewed
Nov 26, 2020
5af06a3
to
2db0d6e
Compare
donequis
previously approved these changes
Nov 26, 2020
rskj-core/src/main/java/co/rsk/net/AsyncNodeBlockProcessor.java
Outdated
Show resolved
Hide resolved
2db0d6e
to
36f7622
Compare
patogallaiovlabs
previously approved these changes
Dec 21, 2020
36f7622
to
20740f8
Compare
20740f8
to
f3ff9f1
Compare
Kudos, SonarCloud Quality Gate passed! |
patogallaiovlabs
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a first step in attempting to improve block propagation process
Description
Phase 1 of block propagation improvements
Motivation and Context
RSK node currently processes all the blocks it receives. In a context of many sibling blocks, this results in a significant processing times and usage of node resources.
This change should decouple block receiving/propagation from its execution (which usually takes significant portion of time).
Note: node should propagate a received block only after passing necessary validations.
How Has This Been Tested?
Types of changes
Checklist: