Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented block propagation enhancements #1326

Merged
merged 10 commits into from
Jan 20, 2021
Merged

Implemented block propagation enhancements #1326

merged 10 commits into from
Jan 20, 2021

Conversation

Vovchyk
Copy link
Contributor

@Vovchyk Vovchyk commented Oct 5, 2020 •
edited

This pull request is a first step in attempting to improve block propagation process

Description

Phase 1 of block propagation improvements

Motivation and Context

RSK node currently processes all the blocks it receives. In a context of many sibling blocks, this results in a significant processing times and usage of node resources.

This change should decouple block receiving/propagation from its execution (which usually takes significant portion of time).

Note: node should propagate a received block only after passing necessary validations.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@Vovchyk Vovchyk marked this pull request as ready for review October 15, 2020 08:14
@fedejinich
Copy link
Contributor

This case should be tested on integration tests 👍

@fedejinich fedejinich mentioned this pull request Oct 27, 2020
Open
@Vovchyk
Copy link
Contributor Author

Vovchyk commented Oct 29, 2020

pipeline: run

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 19, 2020

I didn't follow all the discussion, but I think we should do all the validations that NOT involves access to disk or memory caches, FIRST.

@ajlopez it looks like you're referring to some previous commit. Now the processing logic has changed a bit. Please check it out.

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 19, 2020

pipeline: run

@Vovchyk
Copy link
Contributor Author

Vovchyk commented Nov 19, 2020

pipeline: run

ajlopezrsk
ajlopezrsk previously approved these changes Nov 25, 2020
View reviewed changes
donequis
donequis previously approved these changes Nov 26, 2020
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

87.7% 87.7% Coverage
0.0% 0.0% Duplication

@ajlopezrsk ajlopezrsk merged commit 5a102cb into master Jan 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the block-propagation-imp branch January 20, 2021 22:22
@aeidelman aeidelman added this to the Iris v3.0.0 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patogallaiovlabs patogallaiovlabs patogallaiovlabs approved these changes

@donequis donequis donequis left review comments

@ajlopezrsk ajlopezrsk ajlopezrsk left review comments

@fedejinich fedejinich Awaiting requested review from fedejinich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Iris 3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Vovchyk @fedejinich @donequis @ajlopezrsk @patogallaiovlabs @aeidelman