Peer scoring monitoring and logs improvements #1745

illuque-iov · 2022-03-31T11:40:58Z

Improve Peer Scoring monitoring and logging

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Tests for the changes have been added (for bug fixes / features)
Requires Activation Code (Hard Fork)

Other information:

heitorfm

Its interesting to add some javadoc to new classes, also there are some files missing the license header.

illuque-iov · 2022-03-31T16:46:59Z

Reopening, I think I've closed it by mistake with a shortcut or something...

rskj-core/src/main/java/co/rsk/net/messages/MessageVisitor.java

rskj-core/src/main/java/co/rsk/net/sync/PeersInformation.java

rskj-core/src/test/java/co/rsk/net/sync/PeerAndModeDecidingSyncStateTest.java

rskj-core/src/main/java/co/rsk/scoring/PeerScoring.java

rskj-core/src/main/java/co/rsk/scoring/PeerScoringManager.java

…s failing with this branch codebasae: Issue 1) Current branch is adding some logs and node banning process was a bit slower. - node was banned, for 10ms (before, this was increased now) - we read node reputation expecting it false, but it was true already, node was forgiven because the 10ms had passed before our read Issue 2) Current branch is setting punishmentTime to 0 on endPunishment and merged test was not prepared for that