Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old blocks are ignored when processed #510

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

lsebrie
Copy link
Contributor

@lsebrie lsebrie commented Mar 16, 2018

If the blocks are not close enough by block number when are relayed, then the block will be ignored. If it was a useful block it will be obtained later

ajlopezrsk
ajlopezrsk previously approved these changes Mar 16, 2018
@rskops
Copy link
Collaborator

rskops commented Mar 16, 2018

SonarQube analysis reported 13 issues

  • MAJOR 9 major
  • INFO 4 info

Top 10 issues

  1. MAJOR RskFactory.java#L107: Method has 8 parameters, which is greater than 7 authorized. rule
  2. MAJOR RskFactory.java#L116: This block of commented-out lines of code should be removed. rule
  3. MAJOR RskFactory.java#L144: Method has 19 parameters, which is greater than 7 authorized. rule
  4. MAJOR BlockSyncService.java#L1: Class co.rsk.net.BlockSyncService creates and initializes a collection but never reads or gains information from it rule
  5. MAJOR BlockSyncService.java#L99: Method co.rsk.net.BlockSyncService.processBlock(Block, MessageChannel, boolean) appears to call the same method on the same object redundantly rule
  6. MAJOR NodeBlockProcessor.java#L284: Method co.rsk.net.NodeBlockProcessor.processSkeletonRequest(MessageChannel, long, long) does not presize the allocation of a collection rule
  7. MAJOR NodeMessageHandler.java#L80: Constructor has 8 parameters, which is greater than 7 authorized. rule
  8. MAJOR NodeMessageHandler.java#L106: The Cyclomatic Complexity of this method "processMessage" is 18 which is greater than 10 authorized. rule
  9. MAJOR NodeMessageHandler.java#L346: Method co.rsk.net.NodeMessageHandler.relayBlock(MessageChannel, Block) appears to call the same method on the same object redundantly rule
  10. INFO RskFactory.java#L116: Complete the task associated to this TODO comment. rule

@aeidelman aeidelman merged commit 0e21c2d into master Mar 16, 2018
@aeidelman aeidelman deleted the ignore_old_blocks branch March 16, 2018 21:08
@aeidelman aeidelman added this to the Bamboo v0.4.1 milestone Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants