1 preview configs #887
Merged
1 preview configs #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left a TODO here: https://github.com/rsksmart/rskj/blob/master/rskj-core/src/main/java/org/ethereum/config/blockchain/upgrades/ConsensusRule.java#L23 I was hoping we would tackle it as part of the PR that created a new testnet. Also, shouldn't we change the Genesis, the network id or anything? |
josedahlquist
force-pushed
the
1-preview-configs
branch
4 times, most recently
from
5b6b4ac
to
07f76f4
Compare
lsebrie
previously approved these changes
Jun 18, 2019
josedahlquist
force-pushed
the
1-preview-configs
branch
from
07f76f4
to
8189666
Compare
colltoaction
force-pushed
the
1-preview-configs
branch
from
8189666
to
a651aee
Compare
colltoaction
previously approved these changes
Jun 18, 2019
josedahlquist
force-pushed
the
1-preview-configs
branch
from
a651aee
to
a8f5097
Compare
josedahlquist
force-pushed
the
1-preview-configs
branch
from
a8f5097
to
44d2980
Compare
diega
previously approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.