Conversion issue

[lassebunk]

Hi Russell,

I have this issue:

"test¤test".to_url # => "test$-test"

Thanks,
/Lasse

[rsl]

hrm. what IS that symbol?

[lassebunk]

Don't know :) some user entered input, maybe from Word...

tirsdag den 3. september 2013 skrev Russell Norris :

hrm. what IS that symbol?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-23708305
.

[rsl]

i don't even know how to look it up to see what it should be.

[rsl]

if it should be anything.

[rsl]

http://www.fileformat.info/info/unicode/char/search.htm?q=%C2%A4&preview=entity

[rsl]

http://en.wikipedia.org/wiki/Currency_sign#List_of_presently-circulating_currency_signs

[rsl]

what's the context? i'm not sure anything correct can be done with a 'generic currency symbol'.

[lassebunk]

No context. Just an error some user entered somewhere. Maybe just replace
it with a space?

tirsdag den 3. september 2013 skrev Russell Norris :

what's the context? i'm not sure anything correct can be done with a
'generic currency symbol'.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-23708788
.

[rsl]

is this with locales? i'm kinda thinking defaulting to us with no locale is fine and perhaps adding a default currency for each of the locales. thoughts? not sure this is any more accurate though than just removing.

[lassebunk]

Not sure about the default currency because even in Danish I don't know
what that symbol means. I have usually seen the symbol when importing data
from other systems, i.e. an encoding error or something like that.

2013/9/3 Russell Norris notifications@github.com

is this with locales? i'm kinda thinking defaulting to us with no locale
is fine and perhaps adding a default currency for each of the locales.
thoughts? not sure this is any more accurate though than just removing.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-23709087
.

[lassebunk]

So I think it could be just replaced with a space and then see if anybody
thinks this is wrong. :)

2013/9/3 Lasse Bunk lassebunk@gmail.com

Not sure about the default currency because even in Danish I don't know
what that symbol means. I have usually seen the symbol when importing data
from other systems, i.e. an encoding error or something like that.

2013/9/3 Russell Norris notifications@github.com

is this with locales? i'm kinda thinking defaulting to us with no locale
is fine and perhaps adding a default currency for each of the locales.
thoughts? not sure this is any more accurate though than just removing.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-23709087
.

[rsl]

it's just a generic placeholder-y symbol for 'whatever currency' i think. like... where you might say 'X dollars' and X is generic number... you'd say '10¤' for '10 whatever your currency is'.

[lassebunk]

Ah okay. Don't know what the best solution would be then.

2013/9/3 Russell Norris notifications@github.com

it's just a generic placeholder-y symbol for 'whatever currency' i think.
like... where you might say 'X dollars' and X is generic number... you'd
say '10¤' for '10 whatever your currency is'.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-23717607
.

[rsl]

since the default locale is us, i think it's fine that default says dollars. thinking just adding a default currency to each locale would make this work. so the default translation for that for you would be... krone. [had to look that up]. if not that, then dollar makes as much sense as anything.

[lassebunk]

Up to you. :) – in Danish it's krone as you said and then "kroner" in its
plural form.

2013/9/3 Russell Norris notifications@github.com

since the default locale is us, i think it's fine that default says
dollars. thinking just adding a default currency to each locale would make
this work. so the default translation for that for you would be... krone.
[had to look that up]. if not that, then dollar makes as much sense as
anything.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/140#issuecomment-23718328
.

[rsl]

is there a symbol that should be added for kroner?

[rsl]

added some code to handle this symbol. need review from @glebtv, @widescape, and @guilherme-otran for the russian, german, and portuguese brazilian though.

[glebtv]

Russian is крона, plural is кроны
cents is эре
I don't see it in en.yml

[widescape]

Looks good to me @rsl!

[rsl]

@glebtv mind editing that file for me just to avoid another round of 'is this right'?

also @lassebunk i did use kroner there and it made me wonder if we needed anything to actually handle kroner symbol [DKK?]? this would be a good time to do so i guess.

[lassebunk]

@rsl Kroner i just fine :)
About the DKK, you mean like DKK 1.232,34 => 1.232,34 kroner for example?

[rsl]

@lassebunk yeah

[lassebunk]

I think it could work, although Danish people also write kr. 123,45 or 123,45 kr..

[rsl]

been out of town. thinking supporting things like 'kr. 123' and '123 kr' [in english as well] might be something better added by someone looking to do this concretely rather than me making an abstract change to support something no one has asked for. committing that generic symbol support though.

[lassebunk]

I agree, good call.