to_url returns punctuation '&', ',', etc #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"カッページ・テラスに日系カフェ＆バー、店内にDJブースも - シンガポール経済新聞".to_url => "katupeziterasuniri-xi-kahue&ba,-dian-nei-nidjbusumo-singaporujing-ji-xin-wen"
|
how about add some testcase? |
|
@jlxw can you provide some tests for this? thanks. |
|
blech. can't be merged automatically anymore. prolly need to restart this with some test cases. |
lidaobing
added a commit
to rdd-giga/stringex
that referenced
this pull request
Nov 25, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"カッページ・テラスに日系カフェ＆バー、店内にDJブースも - シンガポール経済新聞".to_url
=> "katupeziterasuniri-xi-kahue&ba,-dian-nei-nidjbusumo-singaporujing-ji-xin-wen"