Fix package.json config #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsms
requested changes
Jan 14, 2020
| @@ -1,7 +1,14 @@ | |||
| { | |||
| "name": "raster", | |||
| "version": "4", | |||
There was a problem hiding this comment.
Can you make this match https://github.com/rsms/raster/blob/master/_data/info.yml and also update https://github.com/rsms/raster/blob/master/misc/dist.sh to rewrite the version number in package.json (so I don’t have to change the version number in two places.)
There was a problem hiding this comment.
Alt make the Jekyll website setup read the version from the package.json (also update the shell scripts in misc in that case as they read the yaml file currently)
Comment on lines
+5
to
+11
| "style": "raster.grid.css", | ||
| "main": "raster.grid.css", | ||
| "files": [ | ||
| "raster.grid.css", | ||
| "raster.css", | ||
| "raster.debug.css" | ||
| ], |
There was a problem hiding this comment.
Since version 20 some of the files have changed names.
- raster.grid.css — only the grid CSS
- raster2.css — full version of Raster (include the grid CSS; no need for raster.grid.css)
- raster2-react.d.ts — React type defs (includes HTML type defs)
- raster2-react.js - HTML runtime code (identical to raster2.js)
- raster2.d.ts - HTML type defs
- raster2.js - HTML runtime code
I think you’ll also want to include LICENSE.txt and template.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for great work ✨
NPM throws errors about absence of fields because the version is not specified by semver
I added the correct version, plus configured everything in order that it was possible to publish a package on NPM