RSocket with Flowable. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehecka
approved these changes
Apr 25, 2017
| LOG(INFO) << "JsonRequestHandler.handleRequestStream " << request; | ||
|
|
||
| // string from payload data | ||
| auto pds = request.moveDataToString(); | ||
| auto requestString = std::string(pds, request.data->length()); | ||
| const char* p = reinterpret_cast<const char*>(request.data->data()); |
There was a problem hiding this comment.
nit: I guess you got tired of writing this code so you eventually created Payload::cloneDataToString method.
Do you want to use it over here?
There was a problem hiding this comment.
This (and all other callers) can just use Payload::moveDataToString() as they consume the Payload.
There was a problem hiding this comment.
I don't understand the question in light of this portion of code.
I created cloneDataToString() because I couldn't get it to work in places where const was required, so I needed a method that copied instead of moved from a const Payload.
The code in question is in ExampleSubscriber:
void ExampleSubscriber::onNext(const Payload& element) noexcept {That expects a const ref, and because of that I can't move data from it.
| LOG(INFO) << "TextRequestHandler.handleRequestStream " << request; | ||
|
|
||
| // string from payload data | ||
| auto pds = request.moveDataToString(); | ||
| auto requestString = std::string(pds, request.data->length()); | ||
| const char* p = reinterpret_cast<const char*>(request.data->data()); |
| LOG(INFO) << "HelloStreamRequestHandler.handleRequestStream " << request; | ||
|
|
||
| // string from payload data | ||
| const char* p = reinterpret_cast<const char*>(request.data->data()); |
| yarpl::Reference<yarpl::Flowable<reactivesocket::Payload>> | ||
| HelloStreamRequestHandler::handleRequestStream( | ||
| reactivesocket::Payload request, | ||
| reactivesocket::StreamId streamId) { | ||
| LOG(INFO) << "HelloStreamRequestHandler.handleRequestStream " << request; | ||
|
|
||
| // string from payload data | ||
| const char* p = reinterpret_cast<const char*>(request.data->data()); |
| * nature of RSocket, this can be used on the client as well. | ||
| */ | ||
| class RSocketRequestHandler { | ||
| public: |
There was a problem hiding this comment.
I am happy to see how this interface doesn't have to do anything with setup/resume initialization.
lexs
reviewed
Apr 25, 2017
| @@ -43,6 +43,13 @@ std::string Payload::moveDataToString() { | |||
| return data->moveToFbString().toStdString(); | |||
| } | |||
|
|
|||
| std::string Payload::cloneDataToString() const { | |||
There was a problem hiding this comment.
implementing the << overload is a bit more idiomatic (and yields nicer code). Like here: https://github.com/ReactiveSocket/reactivesocket-cpp/blob/f1b862a23bc951bbe5869d03321eafa4f583a2a1/src/Common.h#L32
There was a problem hiding this comment.
I was matching the moveDataToString signature. Seems confusing to have one as a name with "move" and another with an operator overload.
There was a problem hiding this comment.
By the way, I did not mean we should not have the << overload. That would be great to have.
It is somewhat confusing though since this type has both data and metadata. So it seems it would have to work for only one of them, or concat them.
|
server client the logs from server processing the client request: |
|
Example code showing how class HelloStreamRequestHandler : public rsocket::RSocketRequestHandler {
public:
/// Handles a new inbound Stream requested by the other end.
yarpl::Reference<yarpl::Flowable<reactivesocket::Payload>>
handleRequestStream(
reactivesocket::Payload request,
reactivesocket::StreamId streamId) override {
LOG(INFO) << "HelloStreamRequestHandler.handleRequestStream " << request;
// string from payload data
auto requestString = request.moveDataToString();
return Flowables::range(1, 10)->map([name = std::move(requestString)](
int64_t v) {
std::stringstream ss;
ss << "Hello " << name << " " << v << "!";
std::string s = ss.str();
return Payload(s, "metadata");
});
}
}; |
|
@lehecka has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This was referenced Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the RSocket APIs to have RSocketRequester and RSocketRequestHandler using Flowable.