fix: add Metadata flag when sending stream payload which has metadata #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>
Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>
viglucci
force-pushed
the
hotfix/responder-metdata-flag
branch
from
7c1bea9
to
d0e13a8
Compare
OlegDokuka
reviewed
Jan 3, 2022
| @@ -888,6 +888,10 @@ class RSocketMachineImpl<D, M> implements RSocketMachine<D, M> { | |||
| flags |= FLAGS.COMPLETE; | |||
| this._subscriptions.delete(streamId); | |||
| } | |||
| if (payload.metadata !== undefined) { | |||
There was a problem hiding this comment.
Suggested change
| if (payload.metadata !== undefined) { | |
| if (payload.metadata != undefined) { |
I would relax restriction here to make sure null also rejected there
There was a problem hiding this comment.
I think would need to be payload.metadata !== undefined && payload.metadata !== null as null won't match undefined even without strict equality check. Latest commit should resolve this.
Signed-off-by: Kevin Viglucci <kviglucci@gmail.com>
viglucci
force-pushed
the
hotfix/responder-metdata-flag
branch
from
39a1fb3
to
639a967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Addresses #198
Modifications:
Add Metadata flag as needed when sending stream payload.
Result:
Metadata should be included in encoded payloads.