Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatch special cases for x ** 1 and x ** 2 #266

Merged
merged 1 commit into from Jul 29, 2020
Merged

Conversation

rsokl
Copy link
Owner

@rsokl rsokl commented Jul 28, 2020

No description provided.

@rsokl rsokl requested a review from petarmhg July 28, 2020 19:31
@codecov-commenter
Copy link

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #266   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         2407      2413    +6     
=========================================
+ Hits          2407      2413    +6     
Impacted Files Coverage Δ
src/mygrad/tensor_base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cdda7...ed74c08. Read the comment docs.

Copy link
Collaborator

@petarmhg petarmhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we also have separate operations for Sqrt and Cbrt, do you also want to check for these cases? I'm not actually sure how worthwhile doing so would be, but otherwise this looks good

@rsokl
Copy link
Owner Author

rsokl commented Jul 29, 2020

True. Although those aren't much more efficient than the pow implementation

@rsokl rsokl merged commit dd29793 into master Jul 29, 2020
@rsokl rsokl deleted the special-case-pow branch July 29, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants