Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer mistake: 'Failed to construct 'PaymentRequest': required member currencyCode is undefined.' #3

Closed
sideshowbarker opened this issue May 23, 2016 · 3 comments

Comments

@sideshowbarker
Copy link

When I try the demos at https://github.com/rsolomakhin/rsolomakhin.github.io/issues I get:

Developer mistake: 'Failed to construct 'PaymentRequest': required member currencyCode is undefined.'

@rsolomakhin
Copy link
Owner

Chrome 53 is introducing breaking changes into the API, the first of which is a switch from currencyCode to currency. This allows for non-standard currencies, which are not ISO codes. I've moved the Chrome 52 functionality under /52/. Here are the Chrome 52 versions:

@sideshowbarker
Copy link
Author

Chrome 53 is introducing breaking changes into the API

OK. But as of today, the latest Chrome Dev version of Chrome for Android is 52, right? (52.0.2739.3 is what my About Chrome on Android shows).

Is there somewhere I can find a Chrome 53 binary for Android (short of building it from the sources myself)? Or in general for the future, a binary that’s ahead of the Chrome Dev releases for Android?

Here are the Chrome 52 versions

Thank you! I can confirm that those work in my Android Chrome Dev 52. (And nice UI btw!)

@rsolomakhin
Copy link
Owner

OK. But as of today, the latest Chrome Dev version of Chrome for Android is 52, right? (52.0.2739.3 is what my About Chrome on Android shows).

Correct.

Is there somewhere I can find a Chrome 53 binary for Android (short of building it from the sources myself)? Or in general for the future, a binary that’s ahead of the Chrome Dev releases for Android?

No way for you to get that, sorry. Chrome Dev updates about once a week. The next Chrome Dev should be version 53. I've updated the test pages on https://rsolomakhin.github.io/ because Chrome engineers are building from source and need the bleeding edge test pages, so to speak.

And nice UI btw!

Thank you! I will pass this on to our UI engineers.

rsolomakhin added a commit that referenced this issue Jun 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants