Update jruby version for CI #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
jruby9220
branch
2 times, most recently
from
3545fc5
to
ae759bc
Compare
jcoyne
approved these changes
Nov 10, 2021
|
Oh thanks! Odd that there is no CI listed here -- does this make CI pass on JRuby? (And we presumably were ok with violating the "can't merge unless CI is green" rule here -- I agree! -- since CI is presumably still failing on ruby 2.4. ) |
jrochkind
reviewed
Nov 10, 2021
|
|
||
| # HTTP.rb (used by solr_wrapper to download solr for integration testing) fails | ||
| # to download the full contents of files (under jruby)? | ||
| gem "http", '< 5', platforms: :jruby |
There was a problem hiding this comment.
This is confusing to me -- do you mean http 5 is what fails to download, and http 4 was ok, is why we're limiting to http 4 here? Should the comment say that? (Thanks for the comment!)
This probably isn't tenable as a long-term solution, but okeydoke.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. to fix SSL certificate verification (see jruby/jruby#6872)