Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @rspack/core as an optional peer dependency #1

Merged
merged 1 commit into from Nov 9, 2023

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Nov 9, 2023

Background

Rspack is a fast Rust-based web bundler and it is compatible with the architecture and ecosystem of webpack.

The html-webpack-plugin can be used with Rspack, but users will get a peer dependency warning:

 WARN  Issues with peer dependencies found
.
 └─┬ html-webpack-plugin 5.5.3
    └── ✕ missing peer webpack@^5.20.0

Description

This PR adds @rspack/core as an optional peer dependency, and make webpack as an optional peer dependency too.

Related issues

@chenjiahan chenjiahan merged commit d45d11d into main Nov 9, 2023
@chenjiahan chenjiahan deleted the add_rspack_peer_1109 branch November 9, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant