deprecate :if and :unless as keys for RSpec.configuration.filter_run_…

…excluding

lib/rspec/core/deprecation.rb

@@ -1,6 +1,8 @@
 module RSpec
 
   class << self
+    # @api private
+    #
     # Used internally to print deprecation warnings
     def deprecate(method, alternate_method=nil, version=nil)
       version_string = version ? "rspec-#{version}" : "a future version of RSpec"

lib/rspec/core/filter_manager.rb

@@ -28,9 +28,11 @@ module BackwardCompatibility
         # TODO - add deprecation warning on :if/:unless
         def update(orig, opposite, *updates)
           if updates.last.has_key?(:unless)
+            RSpec.warn_deprecation("\nDEPRECATION NOTICE: FilterManager#exclude(:unless => #{updates.last[:unless].inspect}) is deprecated with no replacement, and will be removed from rspec-3.0.")
             @exclusions[:unless] = updates.last.delete(:unless)
           end
           if updates.last.has_key?(:if)
+            RSpec.warn_deprecation("\nDEPRECATION NOTICE: FilterManager#exclude(:if => #{updates.last[:if].inspect}) is deprecated with no replacement, and will be removed from rspec-3.0.")
             @exclusions[:if] = updates.last.delete(:if)
           end
 

spec/rspec/core/filter_manager_spec.rb

@@ -124,13 +124,27 @@ module RSpec::Core
         filter_manager.exclusions.description.should eq({ :foo => :bar }.inspect)
       end
 
+      it 'deprecates an overridden :if filter' do
+        RSpec.should_receive(:warn_deprecation).with(/exclude\(:if.*is deprecated/)
+        filter_manager = FilterManager.new
+        filter_manager.exclude :if => :custom_filter
+      end
+
+      it 'deprecates an overridden :unless filter' do
+        RSpec.should_receive(:warn_deprecation).with(/exclude\(:unless.*is deprecated/)
+        filter_manager = FilterManager.new
+        filter_manager.exclude :unless => :custom_filter
+      end
+
       it 'includes an overriden :if filter' do
+        RSpec.stub(:warn_deprecation)
         filter_manager = FilterManager.new
         filter_manager.exclude :if => :custom_filter
         filter_manager.exclusions.description.should eq({ :if => :custom_filter }.inspect)
       end
 
       it 'includes an overriden :unless filter' do
+        RSpec.stub(:warn_deprecation)
         filter_manager = FilterManager.new
         filter_manager.exclude :unless => :custom_filter
         filter_manager.exclusions.description.should eq({ :unless => :custom_filter }.inspect)