deprecate RakeTask#warning (use ruby_opts='-w' instead)

rspec · Sep 8, 2010 · 4fa7bd6 · 4fa7bd6
1 parent 39d3c77
commit 4fa7bd6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rspec/core/rake_task.rb b/lib/rspec/core/rake_task.rb
@@ -20,12 +20,18 @@ class RakeTask < ::Rake::TaskLib
       #   'spec/**/*_spec.rb'
       attr_accessor :pattern
 
+      # Deprecated. Use ruby_opts="-w" instead.
       # When true, requests that the specs be run with the warning flag set.
       # e.g. "ruby -w"
       #
       # default:
       #   false
-      attr_accessor :warning
+      attr_reader :warning
+
+      def warning=(true_or_false)
+        RSpec.deprecate("warning", 'ruby_opts="-w"')
+        @warning = true_or_false
+      end
 
       # Whether or not to fail Rake when an error occurs (typically when examples fail).
       #

diff --git a/spec/rspec/core/rake_task_spec.rb b/spec/rspec/core/rake_task_spec.rb
@@ -56,10 +56,17 @@ def spec_command
     end
 
     context "with warnings on" do
+      before { RSpec.stub(:deprecate) }
+
       it "renders -w before the -S" do
         task.warning = true
         spec_command.should =~ /^-w -S rspec/
       end
+
+      it "warns about deprecation" do
+        RSpec.should_receive(:deprecate)
+        task.warning = true
+      end
     end
 
     context "with ruby options" do