New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize on reduce vs inject #1110
Comments
I remembered one other reason I tend to prefer For a long time, I would forget the ordering of the yielded arguments, especially given that the ordering of the yielded arguments of
Since thinking that through, I've never again had a problem with the block arg ordering of these two. I don't think |
We should paint it green. |
It's an arbitrary choice for me though. |
Using your own style guide to reinforce the argument, tsk, ;) |
no point making a style guide if you don't get to refer to it |
I'm up for reduce, which comes both from other languages and having Sent from my phone please excuse my brevity. On 14 Oct 2013, at 05:47, Xavier Shay notifications@github.com wrote: no point making a style guide if you don't get to refer to it — |
Paint it blue! To me it's arbitrary. I wouldn't personally give PR feedback that it should be one way or another, I don't think there's any win in standardizing it or changing what's there. Bradley Schaefer
|
The rspec code bases are inconsistent here and it would be good to standardize. Quoting the earlier conversation from #1108:
@dchelimsky:
@myronmarston:
@dchelimsky:
@myronmarston:
@dchelimsky:
@JonRowe:
The text was updated successfully, but these errors were encountered: