[help] How can I fail CI early if any examples are focused?

[mikegee]

My spec_helper has the standard:

RSpec.configure do |config|
  config.filter_run focus: true
  config.run_all_when_everything_filtered = true
end

That's great for while I'm working on something, but I want my CI build to fail if I accidentally commit a focused spec.

(also asked here: https://stackoverflow.com/questions/26536694/examine-rspec-examples-without-running-them)

[myronmarston]

RSpec.configure do |config|
  if ENV['CI']
    config.before(:example, :focus) { raise "Should not commit focused specs" }
  else
    config.filter_run focus: true
    config.run_all_when_everything_filtered = true
  end
end

Most CI services (such as travis) set a CI environment variable, or you could set it yourself in your CI build script.

[mikegee]

Thanks!

[myronmarston]

Actually, I wonder if our generated spec_helper.rb should do that automatically.

What do others think?

/cc @rspec/rspec

[waterlink]

Looks useful. And of course with appropriate comment before this if block
(stating about travis CI env variable and not recommending committing
:focus-ed specs).

Best Regards,
Alexey Fedorov,
Sr Ruby Developer, Clojure Developer,
+49 15757 486 476

2014-10-24 2:27 GMT+02:00 Myron Marston notifications@github.com:

Actually, I wonder if our generated spec_helper.rb should do that
automatically.

What do others think?

/cc @rspec/rspec https://github.com/orgs/rspec/teams/rspec

—
Reply to this email directly or view it on GitHub
#1747 (comment).

[cupakromer]

@myronmarston I'm not for making this automatic. I feel like it's a bit too specific. Also, there are times I am working on a feature branch and I do not want CI to run the full suite yet, but I do want it to run my focus specs for the entire build matrix.