-
-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExampleGroup.its(:my_method) should create Example in which subject is modified #22
Comments
The following commits demonstrate one possible implementation: http://github.com/gsterndale/rspec-core/commit/a275d813960ffcc82cb7eb255c7ed15401357db7 http://github.com/gsterndale/rspec-core/commit/d4b365ea1b98e533f90aa57ace98ad6651dfcc2b I'm sternicus on IRC. Hit me up if you'd like me to change anything. |
I merged these commits to a branch and made some modifictations: http://github.com/rspec/rspec-core/tree/32-its http://github.com/rspec/rspec-core/commit/7a0f51206282d9df00df967e3cebe762e697bd90 Feel free to comment on the commit |
Great! I add a couple minor comments in your commit. Thanks. |
Closed by c2df11a |
Calling subject inside the example_block should return a modified subject.
The first argument to its() should be a symbol representing a method name to be called on subject.
For example, the following should pass:
Accessing the subject in a before or after block should be on the implicit or explicit subject, NOT the modified subject. See https://rspec.lighthouseapp.com/projects/5645/tickets/975-update-to-subject-not-available-to-its
The text was updated successfully, but these errors were encountered: