Add a deprecation warning to 2.99 for accessing let/subject from after(:all)
#1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in after(:all)
|
Want to review this @myronmarston ? |
|
|
||
| This is deprecated behavior that will not be supported in RSpec 3. |
There was a problem hiding this comment.
Why did you move this line down below the main blurb?
There was a problem hiding this comment.
It makes more sense to me to have the statement after the explanation, if it's an issue I can move it back.
There was a problem hiding this comment.
It's fine, was just curious.
|
Looks good...left a few comments. |
[skip ci]
|
Merge when green. |
|
I skipped the CI on the changlog change so it's green already. |
JonRowe
added a commit
that referenced
this pull request
Sep 23, 2013
…efore_all Add a deprecation warning to 2.99 for accessing let/subject from `after(:all)`
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…n_warning_let_subject_before_all Add a deprecation warning to 2.99 for accessing let/subject from `after(:all)` --- This commit was imported from rspec/rspec-core@a807624.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1078