Fail build if warnings are emitted. #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, I didn't think of |
This is necessary so that only ruby warnings go to stderr, so that we can fail the build for introducing ruby warnings.
TypeError: $stderr must have write method, RSpec::StdErrSplitter given
JonRowe
added a commit
that referenced
this pull request
Oct 25, 2013
Fail build if warnings are emitted.
|
Nice one :) |
|
Do we want to move this to rspec-support at some point? I did it here as a proof-of-concept more than anything. |
|
I think that's a good idea, I'll take care of it this week On Saturday, 26 October 2013, Myron Marston wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another go at what @xaviershay was trying to achieve in #1117. I tried it by introducing the warning I mentioned in the comments there, and it works :).
Basically, this relies on the fact that ruby prints its warnings to $stderr.