Remove cache busters part 2 #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extend blows the method cache, so it's better to include once at file load time.
Practically, it doesn't matter here, but since our `method_cache_busters` script looks for uses of `extend` this creates one less spot to ignore and the `include` works just fine.
|
LGTM |
myronmarston
added a commit
that referenced
this pull request
Nov 14, 2013
Remove cache busters part 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part two of #1173. In this, I've finished going through the list of method cache busters produced by @xaviershay's script and reviewed each one, addressing a few of them but mostly adding it to the ignore if it only happens at spec definition time.
This also adds a step to the build that will fail if there are any new method cache busters added.