use binstub if present #1241

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@bolandrm

bolandrm commented Jan 6, 2014

Hey,

This updates the rake task to use bin/rspec if it's present.

Please see previous discussion @ rspec/rspec-rails#914

@bolandrm bolandrm referenced this pull request in rspec/rspec-rails Jan 6, 2014

Closed

use bin/rspec if present #914

@myronmarston

This comment has been minimized.

Show comment Hide comment
@myronmarston

myronmarston Jan 6, 2014

Member

The build is failing because the travis build winds up with bin/rspec so that file is present for the specs. To setup and run the build the same locally, do this:

$ bundle install --standalone --binstubs
$ bin/rspec

It would also be nice to having a spec that shows that rspec is used if bin/rspec is not present (even if the test suite was launched from bin/rspec -- you may have to fake it out) and another that shows that bin/rspec is used if present (even if it wasn't originally present when the test suite was launched).

Member

myronmarston commented Jan 6, 2014

The build is failing because the travis build winds up with bin/rspec so that file is present for the specs. To setup and run the build the same locally, do this:

$ bundle install --standalone --binstubs
$ bin/rspec

It would also be nice to having a spec that shows that rspec is used if bin/rspec is not present (even if the test suite was launched from bin/rspec -- you may have to fake it out) and another that shows that bin/rspec is used if present (even if it wasn't originally present when the test suite was launched).

@bolandrm

This comment has been minimized.

Show comment Hide comment
@bolandrm

bolandrm Jan 6, 2014

@myronmarston Sure thing, I'll fix it up.

bolandrm commented Jan 6, 2014

@myronmarston Sure thing, I'll fix it up.

@samphippen

This comment has been minimized.

Show comment Hide comment
@samphippen

samphippen Mar 22, 2014

Member

@bolandrm are you still up for doing this? It'd be cool to see this pull request closed!

Member

samphippen commented Mar 22, 2014

@bolandrm are you still up for doing this? It'd be cool to see this pull request closed!

@xaviershay

This comment has been minimized.

Show comment Hide comment
@xaviershay

xaviershay Mar 22, 2014

Member

Closing, stale.

Member

xaviershay commented Mar 22, 2014

Closing, stale.

@xaviershay xaviershay closed this Mar 22, 2014

@myronmarston

This comment has been minimized.

Show comment Hide comment
@myronmarston

myronmarston Mar 23, 2014

Member

This has personally affected me so I've been planning to wrap this one up. Going to reopen so I don't forget.

Member

myronmarston commented Mar 23, 2014

This has personally affected me so I've been planning to wrap this one up. Going to reopen so I don't forget.

@myronmarston

This comment has been minimized.

Show comment Hide comment
@myronmarston

myronmarston Apr 18, 2014

Member

Closing in favor of #1494.

Member

myronmarston commented Apr 18, 2014

Closing in favor of #1494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment