Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use binstub if present #1241

Closed
wants to merge 1 commit into from
Closed

use binstub if present #1241

wants to merge 1 commit into from

Conversation

bolandrm
Copy link

@bolandrm bolandrm commented Jan 6, 2014

Hey,

This updates the rake task to use bin/rspec if it's present.

Please see previous discussion @ rspec/rspec-rails#914

@myronmarston
Copy link
Member

The build is failing because the travis build winds up with bin/rspec so that file is present for the specs. To setup and run the build the same locally, do this:

$ bundle install --standalone --binstubs
$ bin/rspec

It would also be nice to having a spec that shows that rspec is used if bin/rspec is not present (even if the test suite was launched from bin/rspec -- you may have to fake it out) and another that shows that bin/rspec is used if present (even if it wasn't originally present when the test suite was launched).

@bolandrm
Copy link
Author

bolandrm commented Jan 6, 2014

@myronmarston Sure thing, I'll fix it up.

@fables-tales
Copy link
Member

@bolandrm are you still up for doing this? It'd be cool to see this pull request closed! ✨

@xaviershay
Copy link
Member

Closing, stale.

@xaviershay xaviershay closed this Mar 22, 2014
@myronmarston
Copy link
Member

This has personally affected me so I've been planning to wrap this one up. Going to reopen so I don't forget.

@myronmarston
Copy link
Member

Closing in favor of #1494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants