before/after(:all) hook filtering fix #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple groups. Previously, before/after(:all) hooks in an example group with a nested example group would always be run, even if none of the specs in the example group were run due to inclusion/exclusion filtering. We should only run the before/after(:all) hooks if there are any corresponding examples to run.
|
Merged: 5c655e1 |
timcharper
pushed a commit
to timcharper/rspec-core
that referenced
this pull request
Aug 19, 2011
…ple groups. Previously, before/after(:all) hooks in an example group with a nested example group would always be run, even if none of the specs in the example group were run due to inclusion/exclusion filtering. We should only run the before/after(:all) hooks if there are any corresponding examples to run. - Closes rspec#161.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug with before/after(:all) hooks being run for example groups that have been excluded from running the an inclusion/exclusion filter.