Remove pathname require from ruby_project.rb

Changelog.md

@@ -10,6 +10,7 @@ Enhancements:
   spec runs, whilst retaining user configuration.  (Alexey Fedorov, #1706)
 * Reduce string allocations when defining and running examples by 70%
   and 50% respectively. (Myron Marston, #1738)
+* Removed dependency on pathname from stdlib. (Sam Phippen, #1703)
 
 ### 3.1.7 Development
 [Full Changelog](http://github.com/rspec/rspec-core/compare/v3.1.6...3-1-maintenance)

lib/rspec/core/ruby_project.rb

@@ -1,9 +1,6 @@
 # This is borrowed (slightly modified) from Scott Taylor's
 # project_path project:
 #   http://github.com/smtlaissezfaire/project_path
-
-require 'pathname'
-
 module RSpec
   module Core
     # @private
@@ -29,8 +26,19 @@ def find_first_parent_containing(dir)
       end
 
       def ascend_until
-        Pathname(File.expand_path('.')).ascend do |path|
+        fs = File::SEPARATOR
+        escaped_slash = "\\#{fs}"
+        special = "_RSPEC_ESCAPED_SLASH_"
+        project_path = File.expand_path(".")
+        parts = project_path.gsub(escaped_slash, special).squeeze(fs).split(fs).map do |x|
+          x.gsub(special, escaped_slash)
+        end
+
+        until parts.empty?
+          path = parts.join(fs)
+          path = fs if path == ""
           return path if yield(path)
+          parts.pop
         end
       end
 

spec/rspec/core/ruby_project_spec.rb

@@ -21,6 +21,33 @@ module Core
         end
 
       end
+
+      describe "#ascend_until" do
+        subject { RubyProject }
+
+        def expect_ascend(source_path, *yielded_paths)
+          expect { |probe|
+            allow(File).to receive(:expand_path).with('.') { source_path }
+            subject.ascend_until(&probe)
+          }.to yield_successive_args(*yielded_paths)
+        end
+
+        it "works with a normal path" do
+          expect_ascend("/var//ponies/", "/var/ponies", "/var", "/")
+        end
+
+        it "works with a path with a trailing slash" do
+          expect_ascend("/var//ponies/", "/var/ponies", "/var", "/")
+        end
+
+        it "works with a path with double slashes" do
+          expect_ascend("/var//ponies/", "/var/ponies", "/var", "/")
+        end
+
+        it "works with a path with escaped slashes" do
+          expect_ascend("/var\\/ponies/", "/var\\/ponies", "/")
+        end
+      end
     end
   end
 end