Ruby 2.5 fixes #2497
Merged
Ruby 2.5 fixes #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes part of #2488.
- `Module.new.define_method(:foo) { }` indicates that
`Module#define_method` is private on Ruby < 2.5 and
public on Ruby 2.5.
- The example related to frozen exceptions specified the
behavior using an implementation detail of Ruby < 2.5,
and is no longer applicable on 2.5.
Fixes part of #2488
This Ruby 2.5 feature is causing bugs with our hooks because we depend upon `Hook#==` working properly for the same source hook block. In Ruby 2.5 they introduced lazy proc allocation which can result in two `Hook` instances which were previously correctly considered to be equal to no longer be considered equal. To work around this, we just need to invoke a method on the proc before passing it along to other methods. Note that there might be other bugs introduced by the Ruby 2.5 change, but this fixes the only test failures due to it, so this is all we are changing for now. Fixes #2488.
|
LGTM, thanks for doing this! |
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
Ruby 2.5 fixes
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
…-2-5-fixes Ruby 2.5 fixes --- This commit was imported from rspec/rspec-core@a26887b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should get our test suite to green on Ruby 2.5. Note that https://bugs.ruby-lang.org/issues/14045 introduces a regression in RSpec (see my comment on note #5) so we'll probably need to backport this to the 3-7-maintenance branch and cut a release.