Update terminology in BUILD_DETAIL.md #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 10, 2018
JonRowe
requested changes
Nov 11, 2018
BUILD_DETAIL.md
Outdated
| @@ -40,7 +40,7 @@ The spec suite performs a couple extra checks that are worth noting: | |||
| available for use in any context, we want to minimize how many bits of the standard | |||
| library we load and use. Otherwise, RSpec's use of part of the standard library could | |||
| mask a problem where a gem author forgets to load a part of the standard library they | |||
| rely on. The spec suite contains a spec that defines a whitelist of allowed loaded | |||
| rely on. The spec suite contains a spec that defines a allowlist of allowed loaded | |||
There was a problem hiding this comment.
defines a allowlist of allowed is a bit duplicative, can you change it to just defines a list of allowed
JonRowe
approved these changes
Nov 14, 2018
MatheusRich
pushed a commit
to MatheusRich/rspec-core
that referenced
this pull request
Oct 30, 2020
yujinakayama
pushed a commit
to yujinakayama/rspec-monorepo
that referenced
this pull request
Oct 6, 2021
This commit was imported from rspec/rspec-core@cd07682.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates terminology in
BUILD_DETAIL.md.Allowlist is easier to understand and better terminology.
Original motivation, other community efforts examples: