Update to a version of Rubocop that is compatible with Ruby 2.4-3.1 #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Jan 11, 2022
| @@ -4,76 +4,73 @@ | |||
| # This file contains defaults for RSpec projects. Individual projects | |||
| # can customize by inheriting this file and overriding particular settings. | |||
|
|
|||
| AccessModifierIndentation: | |||
| Layout/AccessModifierIndentation: | |||
There was a problem hiding this comment.
We generally update this file using rspec-dev that can make multiple changes at once, I'd prefer to do that and then add the extra "version bump" commit to those prs by hand.
JonRowe
reviewed
Jan 11, 2022
JonRowe
reviewed
Jan 11, 2022
pirj
reviewed
Apr 7, 2022
pirj
added a commit
to rspec/rspec-dev
that referenced
this pull request
Apr 8, 2022
|
@petergoldstein Thanks a lot for making this happen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to Rubocop that maintains compatibility with Ruby 2.4-3.1 using a common .rubocop_rspec_base.yml file across
rspec-core,rspec-expectations,rspec-mocks, andrspec-supportChanges to this common base configuration file are minimal, limited to:
Each repo now has a .rubocop_todo.yml file which can be worked through at the maintainers leisure.
Some updates to the existing .rubocop.yml files were made, mostly in removing duplication and updating some variables so Rubocop would run green.