New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display both minutes and seconds of duration time when specs are finished. #563

Merged
merged 1 commit into from Jan 30, 2012

Conversation

Projects
None yet
3 participants
@uzzz
Contributor

uzzz commented Jan 28, 2012

As far as lots of rails heavy-weight apps (mine too) runs specs much longer than tens seconds (about 23 minutes on my app for instance) because of hardcore DB seeding I think it will be useful to see "xx minutes xx seconds" in output if duration is more than 1 minute.

@justinko

This comment has been minimized.

Show comment
Hide comment
@justinko

justinko Jan 30, 2012

Contributor

I like this, it keeps me from dividing the minutes by 60 in my head :)

@dchelimsky @myronmarston any objections?

Contributor

justinko commented Jan 30, 2012

I like this, it keeps me from dividing the minutes by 60 in my head :)

@dchelimsky @myronmarston any objections?

@dchelimsky

This comment has been minimized.

Show comment
Hide comment
@dchelimsky

dchelimsky Jan 30, 2012

Member

Nope.

Member

dchelimsky commented Jan 30, 2012

Nope.

justinko pushed a commit that referenced this pull request Jan 30, 2012

Justin Ko
Merge pull request #563 from uzzz/master
Display both minutes and seconds of duration time when specs are finished.

@justinko justinko merged commit e9e31ee into rspec:master Jan 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment