Defines shellescape method #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method allows newer versions of Ruby to use string.shellescape while not breaking in 1.8.6
|
Closing because it's failing. Will fix and re-submit. |
|
@charliemaffitt you don't have to close a pull request to re-submit. You can force push your branch and the pull request will pick it up. Feel free to reopen this and handle it that way. |
|
@dchelimsky I've re-opened it. Thanks for the tip. |
|
It passed when I re-opened it anyway. |
|
Thank you @charliemaffitt! |
alindeman
added a commit
that referenced
this pull request
Nov 18, 2012
…patible Defines shellescape method
|
Turns out this pull request breaks Ruby 1.8.7 too..... |
|
@fiddyspence -- what breakage are you seeing on 1.8.7? |
|
@fiddyspence -- Does d77527f fix the problem you were seeing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method allows newer versions of Ruby to use string.shellescape while not breaking in 1.8.6.
Attempting to solve the issue introduced in this comment:
#721 (comment)