Better fix for let definitions eagerly included #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, this will make behaviour more predictable" This reverts commit ec4056a.
This is in prep for changing when the LetDefinitions module is included. The use of `subject` from the `included` hook was causing problems when I was trying to do that.
It needs to be included last so that its definitions can take precedence in case of a name collision.
This is the current list of what it supports: describe context hooks before append_before prepend_before after prepend_after append_after around run_hook around_each_hooks_for let let! subject subject! its
This was referenced Jun 11, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate fix for #908. It changes when the
LetDefinitionsmodule gets included (delaying it until after configuration has included its modules and the group block has been eval'd) so that its method definitions take precedence when there is a naming collision. The tricky parts were:subjectas module inclusion time.SharedContext-- I rewrote this to use a simpler record/playback mechanism so that all it really does is store stuff that's eval'd on the example group when included.@alindeman / @JonRowe -- thoughts?
BTW, the diff is a bit obfuscated by the fact that this includes a reversion of #937. If you want to see just the diff from what we originally had, you can see it here:
bbc83ce...better-fix-for-let-definitions-eagerly-included